Skip to content

Commit

Permalink
Merge pull request #746 from mlibrary/no-more-legacy-private-firewall
Browse files Browse the repository at this point in the history
Remove unnecessary firewall opening for private SSH
  • Loading branch information
daaang authored Nov 13, 2024
2 parents a346fd8 + 8ead3fb commit 8c6e9fb
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 14 deletions.
7 changes: 0 additions & 7 deletions manifests/profile/networking/firewall/ssh.pp
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,4 @@
port => 22,
block => 'umich::networks::all_trusted_machines',
}

if ! is_publicly_accessible() {
nebula::exposed_port { '100 Legacy Private SSH':
port => 22,
block => 'umich::networks::private_bastion_hosts',
}
}
}
7 changes: 0 additions & 7 deletions spec/classes/profile/networking/firewall/ssh_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,6 @@
block: 'umich::networks::all_trusted_machines',
)
end

it do
expect(subject).to contain_nebula__exposed_port('100 Legacy Private SSH').with(
port: 22,
block: 'umich::networks::private_bastion_hosts',
)
end
end
end
end
Expand Down

0 comments on commit 8c6e9fb

Please sign in to comment.