Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HathiTrust DEV-1058: scrape additional logs for apache #696

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

aelkiss
Copy link
Member

@aelkiss aelkiss commented Jul 12, 2024

I didn't see a way to inject additional logs via lensoftruth, so just adding them here.

@botimer
Copy link
Member

botimer commented Jul 12, 2024

I think this approach is good -- similar to what we have done with Fulcrum, where more of the details are explicit in the Puppet files. It's not a generic library, so binding them here establishes a stronger and more discoverable convention.

I think it's also fine to have this explicit list, though it may be helpful in some cases to know that there is globbing support with the local.file_match component. Using it would require changes to the nebula::log define and template, though.

@botimer botimer merged commit 6c91208 into production Jul 12, 2024
1 check passed
@botimer botimer deleted the HT-DEV-1058-logs branch July 12, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants