DEV-1141: Add Prometheus::Tiny::Shared for all HT perl places #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just FYI I went ahead and installed this manually on macc-ht-ingest-* and beeftea-*, being places where things could conceivably complain. |
Before, this was only installed for web servers (i.e. places with imgsrv) but effectively any place that uses HT perl code (including e.g. for slip) could call functions that need the library.
aelkiss
force-pushed
the
HT-DEV-1141-prometheus-tiny
branch
from
404aa66
to
3f17bdb
Compare
aelkiss
force-pushed
the
HT-DEV-1141-prometheus-tiny
branch
2 times, most recently
from
c999467
to
26e4a31
Compare
Moved to dependencies - not sure this is the best place, but it needs to be somewhere both imgsrv & slip get it
aelkiss
force-pushed
the
HT-DEV-1141-prometheus-tiny
branch
from
26e4a31
to
1f6014a
Compare
|
@rrotter This is finally passing tests if you have a chance to take a look. Thanks! |
|
@rrotter When you have a chance could you merge this? |
rrotter
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, this was only installed for web servers (i.e. places with imgsrv) but effectively any place that uses HT perl code (including e.g. for slip) could call functions that need the library.