HathiTrust DEV-1318: limit access to metrics endpoint #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently attempting to test on preview.babel.hathitrust.org |
|
@daaang Do you have any better recommended way to collect IP addresses of the Kubernetes gateways? |
aelkiss
force-pushed
the
DEV-1318-imgsrv-metrics
branch
2 times, most recently
from
b124b47
to
93dd930
Compare
The metrics endpoint doesn't need to be public, and won't get consistent data coming from it anyway. This limits it to a provided set of IP addresses. While we could try to collect IPs for the prometheus role and the kubernetes gateway, it wasn't immediately clear how to collect the floating IP that the kubernetes gateway uses, so this defers to a set of allowed IP addresses listed in lensoftruth.
aelkiss
force-pushed
the
DEV-1318-imgsrv-metrics
branch
from
93dd930
to
4e2c8d5
Compare
rrotter
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metrics endpoint doesn't need to be public, and won't get consistent data coming from it anyway. This limits it to a provided set of IP addresses. While we could try to collect IPs for the prometheus role and the kubernetes gateway, it wasn't immediately clear how to collect the floating IP that the kubernetes gateway uses, so this defers to a set of allowed IP addresses listed in lensoftruth.