Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove i40e-dkms package #726

Merged
merged 1 commit into from
Oct 16, 2024
Merged

remove i40e-dkms package #726

merged 1 commit into from
Oct 16, 2024

Conversation

rrotter
Copy link
Member

@rrotter rrotter commented Oct 14, 2024

This package was added to work around a buggy ethernet driver in 2018:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=892105

This has surely been patched in the last 6 years. Also, the package no longer works w/ current kernel/debian.

Reverts #37, #38
See also: https://mlit.atlassian.net/browse/AEIM-1502

This package was added to work around a buggy ethernet driver in 2018:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=892105

This has surely been patched in the last 6 years. Also, the package no
longer works w/ current kernel/debian.
Copy link
Member

@skorner skorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from my perspective given:

  • this package no longer works with newer kernels (and is blocking puppet from applying the catalog on hosts calling for it where it can't be run)
  • confirmation (by Ryan in slack) that the package is not currently active on any of the hosts it was intended for and we have not had network problems on those hosts (i.e. we won't be making an updated package)

Copy link
Member

@aelkiss aelkiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do remember the i40e-dkms driver, but I'd defer to @rrotter and @skorner's assessment of the current state, and don't have anything to add -- not sure if I was tagged for review on purpose or not. Let me know if there's anything specific you'd like me to check.

@skorner
Copy link
Member

skorner commented Oct 16, 2024

I think Ryan tagged you due to the historical connection in case you wanted to weigh in. I think Ryan will merge this today. Thanks!

@rrotter rrotter merged commit 7865a49 into production Oct 16, 2024
1 check passed
@rrotter rrotter deleted the rm-i40e-dkms branch October 16, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants