add nginx and open firewall port #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umjnega
force-pushed
the
kubernetes_prometheus
branch
2 times, most recently
from
99765f3
to
6b27eea
Compare
daaang
reviewed
Oct 24, 2024
manifests/profile/prometheus.pp
Outdated
| @@ -146,6 +146,28 @@ | |||
| port => 443, | |||
| block => 'umich::networks::all_trusted_machines', | |||
| } | |||
| } else { | |||
| include nginx | |||
There was a problem hiding this comment.
- include nginx
+ class { 'nginx':
+ server_tokens: 'off',
+ }to make it so the server doesn't display its version in 400 responses, in case we do ever open it to the world.
|
I'm not finding the failure in the details here... help... |
umjnega
force-pushed
the
kubernetes_prometheus
branch
from
f3af972
to
d8aa44e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.