Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collect etcd metrics #733

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Collect etcd metrics #733

merged 1 commit into from
Oct 29, 2024

Conversation

daaang
Copy link
Collaborator

@daaang daaang commented Oct 29, 2024

No description provided.

@daaang
Copy link
Collaborator Author

daaang commented Oct 29, 2024

To make this work, I had to edit /etc/kubernetes/manifests/etcd.yaml by hand:

---listen-metrics-urls=http://127.0.0.1:2381
+--listen-metrics-urls=http://127.0.0.1:2381,http://IP_ADDRESS:2381

skorner
skorner approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@skorner skorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review the technical implementation, but thumbs-up to adding etcd monitoring via metrics collection.

@daaang daaang merged commit 2db69f5 into production Oct 29, 2024
1 check passed
@daaang daaang deleted the monitor-etcd branch October 29, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skorner skorner skorner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daaang @skorner