Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rewrite to point at puma path #734

Merged
merged 1 commit into from
Nov 12, 2024
Merged

update rewrite to point at puma path #734

merged 1 commit into from
Nov 12, 2024

Conversation

umjnega
Copy link
Contributor

@umjnega umjnega commented Oct 29, 2024

I updated the rewrite rule path... I think its correct based on whats in that path on julep-1. Thats where puma is running, from my understanding. Is that correct. @skorner

@umjnega umjnega requested a review from skorner October 29, 2024 15:40
Copy link
Member

@skorner skorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your change would support apache serving static assets from a path local to the web server, but the asstes are not being deployed there. In order to allow the app's puma to serve the static assets, you'll want to remove the conditional rewrite entirely. That will allow the subsequent rewrite to proxy everything to puma.

Once that change is in place, please apply it to macc-www-lib-testing in a puppet env and ask Albert to verify the behavior with a local hosts alias of 141.213.128.250 for mgetit.lib.umich.edu. Thanks!

@rrotter
Copy link
Member

rrotter commented Nov 8, 2024

Did you keep the wrong commit message in the squash? Looks like this is something more like "mgetit: remove static assets rewrite rule".

@skorner
Copy link
Member

skorner commented Nov 8, 2024

+1 to changing the commit message to reflect that the change is about removing the static assets rewrite rule for mgetit rather than an update to it. Thanks!

@umjnega umjnega merged commit ab0bdd1 into production Nov 12, 2024
1 check passed
@skorner skorner deleted the tdx_7298538 branch November 13, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants