Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to puppetlabs/firewall 8.1.1 #743

Merged
merged 3 commits into from
Nov 7, 2024
Merged

upgrade to puppetlabs/firewall 8.1.1 #743

merged 3 commits into from
Nov 7, 2024

Conversation

rrotter
Copy link
Member

@rrotter rrotter commented Nov 6, 2024

No description provided.

- use firewall 8 for exported resources
  - remove `firewall6-` prefix from Firewall collectors
  - add datacenter prefix for haproxy Firewall collector
  - delete all `firewall6-` `@@firewall` exports

- use firewall 8 for all firewall resources
  - s/action/jump/
  - s/provider/protocol/
Using 'jump' here was a breaking change anyway, so just get rid of it.
@rrotter rrotter requested a review from antmoth November 6, 2024 18:31
@rrotter rrotter marked this pull request as ready for review November 6, 2024 18:31
@rrotter rrotter requested a review from skorner November 6, 2024 18:33
Copy link
Collaborator

@daaang daaang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double checked, and I'm seeing -action and -provider on the left and +jump and +protocol on the right. I cannot believe they went with protocol and proto at the same time, where proto is the one that means protocol. Just... embarrassing.

@rrotter rrotter merged commit 10d722f into production Nov 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants