Stop fighting calico #745
Merged
Stop fighting calico #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The newer firewall can get into a weird state when port ranges are defined with hyphens, because in iptables they are defined with colons, so puppet agent will view this as a corrective change. This is not necessarily a problem, but when the host's networking is sufficiently chaotic, this attempt at a corrective change can cause the puppet server to lose the resource in favor of `nil` and crash. Calico is sufficiently chaotic, and this commit also aims to stop purging half of calico's firewall on every puppet agent run.
daaang
force-pushed
the
stop-fighting-calico
branch
from
529f14c
to
69de977
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.