commit additional apt keys #747
Merged
+154
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid log spam and breakage caused by downloading these files from web servers we don't control, add every key that has either updated needlessly (in some cases on EVERY puppet run!) or not been updated when it should have been. Both issues are suspected to be the result of incorrect HTTP headers on the servers we download these keys from.
rrotter
force-pushed
the
apt_keychain
branch
from
d78dd31
to
5deb2a3
Compare
daaang
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
I guess my only question is whether changes to nebula will be picked up. We know that different https servers outside our control behave differently—or in other words, it is conceivable that changes here will be ignored in cases where the file is already present on a target machine.
But it's fine to wait until it matters to find out for certain, and it doesn't matter today.
| adoptium.asc https://packages.adoptium.net/artifactory/api/gpg/key/public | ||
| docker.asc https://download.docker.com/linux/debian/gpg | ||
| k8s.io.asc https://pkgs.k8s.io/core:/stable:/v1.31/deb/Release.key | ||
| puppetlabs.asc https://apt.puppetlabs.com/pubkey.gpg |
There was a problem hiding this comment.
Nice documentation of where these are sourced—we definitely won't regret having this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid log spam and breakage caused by downloading these files from web servers we don't control, add every key that has either updated needlessly (in some cases on EVERY puppet run!) or not been updated when it should have been.
Both issues are suspected to be the result of incorrect HTTP headers on the servers we download these keys from.