Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial implementation of stimuli and references #16

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pmai
Copy link
Collaborator

@pmai pmai commented Oct 20, 2023

This provides a first draft of how stimuli and references could be provided for an SSD system, as part of one or more DefaultExperiment elements.

Further refinement and documentation is needed, this should serve as a discussion starter.

@pmai pmai added the enhancement New feature or request label Oct 20, 2023
@pmai pmai added this to the 2.0-alpha.1 milestone Oct 20, 2023
@pmai pmai requested review from klausschuch and DagBruck October 20, 2023 09:07
@pmai pmai self-assigned this Oct 20, 2023
Copy link
Contributor

@DagBruck DagBruck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, the wording requires mapping to a CSV file? I think it should allow for other file formats at the the discretion of the implementation, but I'm ok with requiring that all implementations should support at least CSV.

@JochenKoehler
Copy link
Collaborator

Web meeting 2023-11-24

  1. Ask potential users for the value of that approach in order to come to a decision for proceeding on that approach
  2. Use case description should be added as rationale for this approach

@pmai
Copy link
Collaborator Author

pmai commented Mar 1, 2024

If I understand correctly, the wording requires mapping to a CSV file? I think it should allow for other file formats at the the discretion of the implementation, but I'm ok with requiring that all implementations should support at least CSV.

Just for the record: The approach already allows any other formats, just as we allow all kinds of formats for parameter sets, etc. It's just that only the CSV approach is required/mandated by the standard.

@DagBruck DagBruck marked this pull request as ready for review March 14, 2024 15:32
@JochenKoehler JochenKoehler removed this from the 2.0-alpha.1 milestone Mar 15, 2024
@JochenKoehler
Copy link
Collaborator

Web meeting 2024-03-15:

Waiting for discussions in FMI community and follow that approach when discussion is finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants