[stdlib] Mark ListLiteral.get as unsafe and introduce __getitem__.
#3991
+26
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua James Venter <[email protected]>
Signed-off-by: Joshua James Venter <[email protected]>
jjvraw
commented
Feb 9, 2025
| @@ -854,13 +854,13 @@ struct object( | |||
|
|
|||
| @parameter | |||
| if _type_is_eq[T, Int](): | |||
| self._append(value.get[i, Int]()) | |||
| self._append(value.unsafe_get[i, Int]()) | |||
There was a problem hiding this comment.
Question: Alternatively, removing get entirely, following the changes of Tuple?
Suggested change
| self._append(value.unsafe_get[i, Int]()) | |
| self._append(rebind[Int](value[i])) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark
ListLiteral.getas unsafe to make type rebinding more explicit, to help prevent crashes similar to that seen withTuple.get(#3935). Also addressing #319, introducing__getitem__by forwardingTuple.__getitem__.