This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
feat: Add optional header parameter to the addProduct function in cart module #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samblacklock
changed the title
samblacklock
suggested changes
Feb 21, 2023
samblacklock
approved these changes
Feb 21, 2023
|
🎉 This PR is included in version 20.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Added optional header parameter to addProduct function in cart moduleDescription
As of now, currency is set at gateway level during Motlin gateway initialization. If the gateway is initialized based on a singleton pattern, it's difficult to reuse the same gateway across multiple apis from a storefront that handles multiple currencies. One solution would be to use a request scoped gateway initialization which is an expensive approach as the number of requests gets higher. An alternative way is to pass currencies as optional parameters with addProduct or similar APIS which makes it more flexible to use.
Dependencies
N/A
##Issue Link
#769