-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BOM generation. #1569
base: main
Are you sure you want to change the base?
Add BOM generation. #1569
Conversation
- Add BOM validation. JAVA-3808
The generated BOM POM is available in the snapshot repository for review: Snapshot Repo Link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - one nit
Good work with the scala multiversion handling 👍
artifactId = "bom".equals(project.archivesBaseName) ? "mongodb-driver-bom" : project.archivesBaseName | ||
from components.javaPlatform | ||
|
||
// Modify the generated POM to add multiple compile versions of driver-scala or bson-scala. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch 👍
api(project(":bson-scala")) | ||
api(project(":driver-scala")) | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: no ending new line.
api(project(":bson-scala")) | ||
api(project(":driver-scala")) | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | |
} | |
This PR introduces a Bill of Materials (BOM) to improve dependency version management, ensure compatibility, and prevent conflicts caused by transitive dependencies.
Motivation
Changes
A BOM defines compatible versions of
mongodb-driver-sync
,mongodb-driver-core
, and related components.Importing the BOM into the
dependencyManagement
section ensures consistent versions across the dependency tree and eliminates mismatches.Example of usage in Maven:
JAVA-3808