Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OIDC k8s provider #1576

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

katcharov
Copy link
Contributor

@katcharov katcharov requested a review from nhachicha December 5, 2024 22:43
Comment on lines 987 to 998
- name: "oidc-auth-test-k8s"
commands:
- command: ec2.assume_role
params:
role_arn: ${aws_test_secrets_role}
duration_seconds: 1800
- func: "oidc-auth-test-k8s-func"
vars:
VARIANT: eks
# - func: "oidc-auth-test-k8s-func" TODO disabled, memory issue, consider forking and increasing here: https://github.com/mongodb-labs/drivers-evergreen-tools/commit/4bc3e500b6f0e8ab01f052c4a1bfb782d6a29b4e
# vars:
# VARIANT: gke
Copy link
Contributor Author

@katcharov katcharov Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variant is disabled due to failure:

 [2024/12/05 13:34:17.109] Compiling build file '/tmp/test/build.gradle' using BuildScriptTransformer.
 [2024/12/05 13:34:17.109] Starting process 'command 'git''. Working directory: /tmp/test Command: git describe --tags --always --dirty
 [2024/12/05 13:34:22.782] debconf: delaying package configuration, since apt-utils is not installed
 [2024/12/05 13:34:22.782] command terminated with exit code 137

See note in TODO comment (must be removed before merging).

Otherwise, eks and aks are both passing.

Comment on lines -264 to 272
new DropDatabaseOperation(getDefaultDatabaseName(), WriteConcern.ACKNOWLEDGED).execute(getBinding());
try {
new DropDatabaseOperation(getDefaultDatabaseName(), WriteConcern.ACKNOWLEDGED).execute(getBinding());
} catch (MongoCommandException e) {
// if we do not have permission to drop the database, assume it is cleaned up in some other way
if (!e.getMessage().contains("Command dropDatabase requires authentication")) {
throw e;
}
}
cluster.close();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of this PR, we will sometimes lack permission to drop the database.

@katcharov katcharov marked this pull request as ready for review January 30, 2025 17:20
@jyemin jyemin requested a review from vbabanin February 4, 2025 22:27
@katcharov katcharov removed the request for review from nhachicha February 5, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant