JAVA-5774 Allow all property types for Filter.regex() #1619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure I fully understand the usecase could you please add some test cases? That should help. |
jenssuhr
force-pushed
the
MIRA-5774-regex-restrictions
branch
from
75bd37c to
b9f235b
Compare
Sure, I can do that |
|
Oops, forgot that renaming the source branch closes the PR |
…ter on a non-String (value class) property
|
I've added an example for filtering on a property with a value class type, but it would also be useful for data classes with a custom codec that serialize into a string. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it makes some sense to only allow the
regexfunction on String properties, this also precludes using it with properties that wrap the String in a value class.To allow for that use case, I think it would make sense to relax the property type and allow anything there.