Override PIE download URL and set build-path for pre-packaged source #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgrim
commented
Feb 4, 2025
composer.json
Outdated
| @@ -17,6 +17,8 @@ | |||
| }, | |||
| "php-ext": { | |||
| "extension-name": "mongodb", | |||
| "override-download-url-method": "pre-packaged-source", | |||
There was a problem hiding this comment.
Needs php/pie#187 to be merged before this will work
asgrim
force-pushed
the
allow-install-with-pie
branch
from
a528c49 to
eb302a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We worked on php/pie#39 to allow the
mongodbextension to be built from pre-packaged source URLs instead of relying on the git-generated ZIP archive that GitHub etc. uses (and thus Composer/PIE).Note:
build-pathis also needed, and I added a template for it, since the TGZ produced has a subdirectory in it based on the version; so in the case ofmongodbat least, we'll need bothdownload-url-methodandbuild-pathto be specified.Note 2: needs php/pie#187 to be merged first