Restrict Pydantic dependency to version 1.x or 2.x #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `json()` method was renamed to `model_dump_json()` in Pydantic 2.0. The old name is still supported in Pydantic 2.x, but is scheduled for removal in Pydantic 3.0. https://docs.pydantic.dev/2.5/migration/#changes-to-pydanticbasemodel Closes monim67#113
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Purpose
The
json()method was renamed tomodel_dump_json()in Pydantic 2.0. The old name is still supported in Pydantic 2.x, but is scheduled for removal in Pydantic 3.0.Revelant docs.
Approach
To prevent the date picker breaking when Pydantic 3.0 is released, the declared Pydantic dependency is limited to versions 1.x and 2.x.
Issues solved in this PR
What has Changed
pyproject.tomlpoetry.lock(locked versions not changed)