Set the addon_icon_class context on the widget key #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR addresses an issue where the picker icons are not showing in the latest version (5.0.5) of
django-bootstrap-datepicker-pluswhen using a customMultiWidgetinput withDatePickerInputandTimePickerInput. This issue was originally raised in this GitHub issue.Approach
This change fixes the missing picker icons by adjusting the context returned by
BasePickerInput. Specifically, it modifies the context dictionary to correctly pass theaddon_icon_classto the widget template.Issues solved in this PR
MultiWidgetinput.What has Changed
_base.pyto ensure theaddon_icon_classis passed correctly in the context.input.htmltemplate to usewidget.addon_icon_classinstead ofaddon_icon_class.