Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm64: dts: qcom: msm8916-xiaoxun-jz0145-v33: Add initial device tree #386

Closed

Conversation

rcky844
Copy link

@rcky844 rcky844 commented Jan 13, 2025

This commit implements support for the JZ0145 v33 WiFi/LTE dongle based on MSM8916.

The manufacturer's name has been derived from the name printed on the packaging label, but the full company name cannot be deduced, as the vendor that sold this item had closed down their online store.

The kernel has only been tested with d410c's TZ firmware, but it is known that the stock bootloader paired with lk2nd could be used as well. However, enabling all CPU cores would require the use of lk1st.

Currently supported / tested:

  • All CPU cores
  • Buttons
  • LEDs
  • Modem
  • SDHC
  • USB Device Mode
  • UART

Add a vendor prefix for XiaoXun BiCheng Technology, which was an online
store on TaoBao selling 4G LTE WiFi modems.

TaoBao mostly require stores to be operated by companies, so they are
a valid vendor. However, this company has ended operations recently.

Signed-off-by: Ricky Cheung <[email protected]>
@rcky844 rcky844 marked this pull request as ready for review January 13, 2025 16:05
@rcky844
Copy link
Author

rcky844 commented Jan 13, 2025

My JZ0145 actually died because its EMMC crapped out when I tried to write too much to it, but I am sure this patch would work fine.

Copy link
Member

@TravMurav TravMurav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Would you mind sending this series upstream? This looks trivial enough so I'd prefer if I could pick this as FROMLIST: patch and drop from our queue later to keep maintenance work down.

If you haven't submitted things before, you can use b4 per the following guide: https://people.kernel.org/monsieuricon/sending-a-kernel-patch-with-b4-part-1
with some more notes available here: https://wiki.postmarketos.org/wiki/Submitting_Patches

@rcky844
Copy link
Author

rcky844 commented Jan 14, 2025

Nice work! Would you mind sending this series upstream? This looks trivial enough so I'd prefer if I could pick this as FROMLIST: patch and drop from our queue later to keep maintenance work down.

If you haven't submitted things before, you can use b4 per the following guide: https://people.kernel.org/monsieuricon/sending-a-kernel-patch-with-b4-part-1 with some more notes available here: https://wiki.postmarketos.org/wiki/Submitting_Patches

First time submitting patches to the LKML, will certainly be an experience. I will get that sorted.

Ricky Cheung added 2 commits January 14, 2025 21:31
Document the MSM8916-based 4G LTE WiFi modem.

Signed-off-by: Ricky Cheung <[email protected]>
This commit implements support for the JZ0145 v33 WiFi/LTE dongle
based on MSM8916, which was sold by XiaoXun BiCheng Technology.

The stock bootloader could boot with this patch with lk2nd, but only
one CPU core would be enabled. Enablement for all CPU cores require
lk1st and d410c firmware files.

Currently supported / tested:
- All CPU cores
- Buttons
- LEDs
- Modem
- SDHC
- USB Device Mode

Although I do not have UART equipment on hand, UART should function
and is labelled on the PCB of this device.

Signed-off-by: Ricky Cheung <[email protected]>
@rcky844
Copy link
Author

rcky844 commented Jan 14, 2025

@TravMurav
Copy link
Member

Picked from the list into wip/msm8916/6.13-rc7 branch, thanks!

d67d92d

@TravMurav TravMurav closed this Jan 14, 2025
@rcky844
Copy link
Author

rcky844 commented Jan 14, 2025

Picked from the list into wip/msm8916/6.13-rc7 branch, thanks!

d67d92d

Small issue, you should pick the v2 of this patch, I noticed an issue with tabs after sending the first one

Please use https://lore.kernel.org/linux-devicetree/[email protected]/, and then force push, many thanks.

@TravMurav
Copy link
Member

Updated to eec8628 but I will probably keep it as is now until the patch lands into qcom tree to keep the churn down.

Also to note, you forgot to update "changes in v2" section of your cover letter (no need to resend just for that but may want to follow up with in-line response to the cover letter stating what you've changed so reviewers understand it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants