Add motorola ocean #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barni2000
requested changes
Aug 12, 2023
| Comment "Earpiece playback" | ||
|
|
||
| ConflictingDevice [ | ||
| "Headphones" |
There was a problem hiding this comment.
Quinary devices should not conflict with Primary devices
| Comment "Headphones playback" | ||
|
|
||
| ConflictingDevice [ | ||
| "Earpiece" |
There was a problem hiding this comment.
Quinary devices should not conflict with Primary devices
barni2000
requested changes
Aug 24, 2023
| "Mic2" | ||
| ] | ||
|
|
||
| Include.smes.File "/codecs/msm8953-wcd/HeadsetMicEnableSeq.conf" |
barni2000
reviewed
Aug 27, 2023
| } | ||
| } | ||
|
|
||
| #Speaker is also the Earpiece |
There was a problem hiding this comment.
If speaker and earpiece is same than you should keep Speaker, and remove Earpiece i don't see any advantage of keep both of them.
| CapturePCM "hw:${CardId},1" | ||
| CaptureChannels 2 | ||
| CapturePriority 400 | ||
| JackControl "Headset Jack" |
There was a problem hiding this comment.
Suggested change
| JackControl "Headset Jack" | |
| JackControl "Mic Jack" |
| PlaybackPCM "hw:${CardId},0" | ||
| PlaybackPriority 300 | ||
| PlaybackChannels 2 | ||
| JackControl "Headset Jack" |
There was a problem hiding this comment.
Suggested change
| JackControl "Headset Jack" | |
| JackControl "Headphone Jack" |
|
On motorola-potter has one speaker for earpiece and speaker but both codec is connected to it, for higher volume it using speaker codec for voice calls it uses different path. Is not wcd codec used for earpiece? |
barni2000
requested changes
May 11, 2024
| ] | ||
|
|
||
| Value { | ||
| PlaybackPCM "hw:${CardId},2" |
barni2000
force-pushed
the
master
branch
2 times, most recently
from
6b5b7a5 to
20ccb0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.