New package: mingw-w64-aws-sdk-cpp

[jeroen]

This is a dependency that a lot of other libraries are interested in. Upstream doesn't officially support mingw yet (they would like to), so this is based on open pull requests from aws/aws-sdk-cpp#1333 and awslabs/aws-c-common#604. I added a patch to make it build on 32-bit and also with older versions of the mingw crt.

It is recommended by upstream to build a static libs (you get linking errors when building shared): aws/aws-sdk-cpp#1309

[1480c1]

Perhaps it might be better to split the cmake changes and the c source file changes into two patches for easier rebasing and managing?

[jeroen]

Perhaps it might be better to split the cmake changes and the c source file changes into two patches for easier rebasing and managing?

The patch is copied from aws/aws-sdk-cpp#1333. I think it's ok to keep them together; there is only a single cmake change in the patch.

[jeroen]

Thanks so much for your suggestions @1480c1 ! I did not know it was possible to generate ninja files from cmake, very cool.

Do you think it looks ready now?

[1480c1]

Overall lgtm, although I haven't personally built or tested it

[jeroen]

Awesome!! 🚀

[jeroen]

cc: @ihnorton @kou @xhochy @nealrichardson, once the binaries are available, we can enable S3 support in arrow and tiledb.

[Biswa96]

I am thinking to separate out the dependencies to different packages, like ArchLinux does. Any thought on that? Also ArchLinux seems to use shared libraries. If shared libraries are enabled would it create any issue with other dependent packages?

[jeroen]

I think that is fine, though I'm not sure what the benefit would be. The full aws-sdk-cpp consists of many inter-dependent libraries, I think it would be quite complex to package them all separately with proper dependencies. Also I am not sure about the ABI stability; I think if you build shared libraries, you may need to rebuild arrow/tiledb for every revision of the aws-sdk-cpp.