Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Sync team page with HiBob #45165

Merged

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Feb 1, 2025

Sync with https://tools-public.mui.com/prod/pages/muicomabout using:

/**
* The teamMembers data can be imported from: https://tools-public.mui.com/prod/pages/muicomabout
curl 'https://tools-public.mui.com/prod/api/data/muicomabout/queryAbout' \
-H 'content-type: application/json' \
--data-raw '{}' \
--compressed
*/

We are not quite yet fully automated. But the diff starts to be really small. One step closer to fix https://www.notion.so/mui-org/ops-Scaling-mui-com-about-page-ba1ac2819df44b97b02a41a2d9b40ed0. If we wanted to fully fix it, we would need to:

  • 1. Create a script to replace the manual work of updating docs/data/about/teamMembers.json.
  • 2. Find a way to store images. Some kind of a CMS, to replace the images.
  • 3. Have the data pulled live rather than store it in git.
  1. could be done with Notion and a field in HiBob (maybe Netlify image CDN in between to optimize the loading). 3. is not important, I wouldn't trust it so much.

This should also work to display a team section for each open-source project, now arguably for those, the need to automate it is less of a concern, can help a bit.

Preview: https://deploy-preview-45165--material-ui.netlify.app/about/

I also removed the image we forgot in #45025.

The new onboarding instructions: https://www.notion.so/mui-org/XXX-s-onboarding-c980eff81a1e405bb36476d0cf22b5e6?pvs=4#18ecbfe7b66080b6bb14c83822f435eb and offboarding: https://www.notion.so/mui-org/Update-mui-com-about-page-7df39bd53ebd423796590e3ef618c774.

@oliviertassinari oliviertassinari added the website Pages that are not documentation-related, marketing-focused. label Feb 1, 2025
@mui-bot
Copy link

mui-bot commented Feb 1, 2025

Netlify deploy preview

https://deploy-preview-45165--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 9fa0ca3

@oliviertassinari oliviertassinari force-pushed the update-about-page-victor branch from 94150de to 0a1d00e Compare February 2, 2025 00:22
@oliviertassinari oliviertassinari force-pushed the update-about-page-victor branch 8 times, most recently from fd0b63e to afd2a9b Compare February 2, 2025 13:13
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 4, 2025
@oliviertassinari oliviertassinari force-pushed the update-about-page-victor branch from 7ba4fd5 to 26cf20a Compare February 5, 2025 14:17
@oliviertassinari oliviertassinari added v6.x needs cherry-pick The PR should be cherry-picked to master after merge labels Feb 5, 2025
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 5, 2025
@oliviertassinari oliviertassinari force-pushed the update-about-page-victor branch from b0287f1 to 7e257cc Compare February 5, 2025 15:12
@oliviertassinari oliviertassinari merged commit ac5c4cb into mui:master Feb 5, 2025
22 checks passed
Copy link

github-actions bot commented Feb 5, 2025

Cherry-pick PRs will be created targeting branches: v6.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs cherry-pick The PR should be cherry-picked to master after merge v6.x website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants