Add Slots to rating #45295
Add Slots to rating #45295
Conversation
Netlify deploy previewhttps://deploy-preview-45295--material-ui.netlify.app/ Bundle size report |
|
|
||
| export interface RatingOwnProps { | ||
| export interface RatingOwnProps extends RatingSlotsAndSlotProps { |
There was a problem hiding this comment.
@siriwatknp @DiegoAndai is this the correct place to extend with RatingSlotsAndSlotProps? pnpm proptypes isn't generating the relevant docs for slots and slotProps in rating.js
Cant see what i've missed, a hint would be greatly appreciated 🤟
There was a problem hiding this comment.
There was a problem hiding this comment.
@DiegoAndai, no still the same 🙃
There was a problem hiding this comment.
It has to be added to the RatingTypeMap, not RatingOwnProps, does it work with that change?
There was a problem hiding this comment.
@DiegoAndai yeah, thats what I did. Here is the commit changes dab6cfb.
line 163 of rating.d.ts, it still only updates the deprecated line in the rating.js and completely ignores the slots.
part of #41281
This PR adds slot the slot prop to rating, whilst deprecating components.
props.iconContainerComponent -> slot.iconContainer
[/] I have followed (at least) the PR section of the contributing guide.