Skip to content

Commit

Permalink
[test] Conditionally skip flaky tests (#4627)
Browse files Browse the repository at this point in the history
  • Loading branch information
Janpot authored Jan 22, 2025
1 parent 3ae14d4 commit 6820cec
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
8 changes: 7 additions & 1 deletion test/integration/propControls/basic.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,13 @@ test.use({
},
});

test('can control component prop values in properties control panel', async ({ page }) => {
test('can control component prop values in properties control panel', async ({
page,
browserName,
}) => {
// TODO: fix flakyness
test.skip(browserName === 'firefox', 'This test is flaky in firefox');

const editorModel = new ToolpadEditor(page);

await editorModel.goto();
Expand Down
5 changes: 4 additions & 1 deletion test/integration/propControls/defaults.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@ test.use({
},
});

test('changing defaultValue resets controlled value', async ({ page }) => {
test('changing defaultValue resets controlled value', async ({ page, browserName }) => {
// TODO: fix flakyness
test.skip(browserName === 'firefox', 'This test is flaky in firefox');

const editorModel = new ToolpadEditor(page);
await editorModel.goto();

Expand Down

0 comments on commit 6820cec

Please sign in to comment.