test script robustness and flexibility #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Match fish{1,2}.png instead of fish[12].png since it's an error if the
file is not found.
Gbp-Pq: Name 0001-test-robust-expansion.patch
Optionally pass executable to test to test/run_tests.bash in $pdiff Gbp-Pq: Name 0002-test-executable.patch
Optionally pass ${script_directory} where test data files live.
Gbp-Pq: Name 0003-test-script_directory.patch
Optionally pass ${tmpdir} where files are written.
Gbp-Pq: Name 0004-test-tmpdir.patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debian and other distributions like to be able to run tests both at built time, against the built package, and at a separate test time, where they're run against an installed binary package. To simplify this, the test script here needs to allow an external argument to tell it where the executable to be tested lives, and to write files to a temp directory instead of in the source tree.
With these patches it seems to work fine both at build time and for testing an out-of-tree binary.