Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create Dockerfile #30

Merged
merged 2 commits into from
Mar 18, 2024
Merged

feat: create Dockerfile #30

merged 2 commits into from
Mar 18, 2024

Conversation

reesedychiao
Copy link
Collaborator

No description provided.

@reesedychiao reesedychiao requested a review from n30w March 18, 2024 02:28
n30w
n30w requested changes Mar 18, 2024
View reviewed changes
Copy link
Owner

@n30w n30w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be changing some things in this. For example, the FROM node line and using yarn instead of npm.

build(next): update Dockerfile
0107ed0 
Use corepack and yarn
@n30w n30w merged commit c457617 into main Mar 18, 2024
2 checks passed
@n30w n30w deleted the 6-containerize-nextjs-development-environment branch March 18, 2024 11:11
@n30w n30w added the enhancement New feature or request label Mar 18, 2024
@n30w n30w mentioned this pull request Mar 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n30w n30w n30w approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reesedychiao @n30w