Update to Ukrainian holidays in UkraineHolidayProvider.cs #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to Ukraine Holidays Victory Day over Nazism in World War II changed to 03.08 starting from 2024 Deleted Julian Christmas starting from 2024 Changed Defender of Ukraine Day dates to be accurate from 2015 to 2023 and from 2023 onward. All new dates are inline with original source https://en.wikipedia.org/wiki/Public_holidays_in_Ukraine
|
if i have researched it correctly, december 25 would only be introduced in ukraine from 2017, perhaps we could also map it right away |
|
Yes, you are right, I will add this change also. |
Added that Gregorian Christmas celebration in Ukraine stared officially from 2017.
|
@tinohager added all the changes, waiting for approval. |
tinohager
approved these changes
Sep 17, 2024
| @@ -58,7 +51,7 @@ protected override IEnumerable<HolidaySpecification> GetHolidaySpecifications(in | |||
| }, | |||
| new HolidaySpecification | |||
| { | |||
| Date = new DateTime(year, 5, 9), | |||
| Date = new DateTime(year, 5, year < 2024 ? 9 : 8), | |||
There was a problem hiding this comment.
please also outsource the logic to a separate method we want to keep the code clean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to Ukraine Holidays
Victory Day over Nazism in World War II changed to 03.08 starting from 2024 Deleted Julian Christmas starting from 2024
Changed Defender of Ukraine Day dates to be accurate from 2015 to 2023 and from 2023 onward. All new dates are inline with original source https://en.wikipedia.org/wiki/Public_holidays_in_Ukraine