Add extension method and corresponding unit tests to convert (unparse… #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…) a collection of TldRules to text
|
somehow I think there are too many changes in the pull request |
|
This pull requests only adds a single extension method and corresponding unit tests. Please reconsider |
|
@tinohager any problems with this pull request that adds an extension method to unparse a collection of TldRules to text? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds an extension method to unparse a collection of TldRules to text. This is needed for more advanced caching scenarios.
Since ICacheProvider only operates on string, situations where the text representation of the TldRules is no longer available cannot use caching. With the extension method, any collection of TldRules can be converted to their text representation , such that they can be added to a cacheprovider.