-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade To Expo 52 #1381
base: master
Are you sure you want to change the base?
Upgrade To Expo 52 #1381
Conversation
Existing types in @types/react-timeago are wrong and need updating to match package latest version
0ac2279
to
f4eb6b3
Compare
bf0d15b
to
88cc496
Compare
88cc496
to
a782ec1
Compare
4caeecf
to
25362c3
Compare
e3e1c9a
to
05400f0
Compare
05400f0
to
423e11e
Compare
fe6c35d
to
6cd018d
Compare
ed14a09
to
f0ab138
Compare
adab65d
to
c7b3a95
Compare
c1faaee
to
7fcd8bd
Compare
7fcd8bd
to
8480f3a
Compare
Original auto-generated comment, containing non-functional links since it was written assuming that project was using Expo Go, which is not the case any more (we are now using Expo development builds):
|
Visit this link to download and install the apk of the latest build on an android phone: https://expo.dev/accounts/nearform/projects/optic-expo/builds/c943150a-f650-44e7-8819-878f692c390f |
console.log('Google sign in cancelled') | ||
} | ||
} catch (error) { | ||
if (GS.isErrorWithCode(error)) { | ||
switch (error.code) { | ||
case GS.statusCodes.IN_PROGRESS: | ||
console.log('Google auth already in progress') | ||
break | ||
case GS.statusCodes.PLAY_SERVICES_NOT_AVAILABLE: | ||
console.log('Google play services not available') | ||
break | ||
default: | ||
console.log('Google sign in error', error) | ||
} | ||
} else { | ||
console.log('An unexpected error occurred,', error) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of just logging errors, this should be surfaced to the user in an alert, toast or notification popup.
Upgrade To Expo 52
Closes #1054
Changes:
create-expo-app
, upgrading to Expo 52FIXME
complete laternpx expo install expo --fix
npx expo-doctor@latest
Check Apple authentication method and update if necessary- not doing this for nowrequire
are still necessary, migrate any that need itCheck - do we want to enable the new architecture (- marked as TODO insteadnewArchEnabled: true
, which would be set true by default in a new Expo 52 app)Check - do we want to swap to new beta- marked as TODO insteadexpo-file-system/next
APIFIXME
notes have been addressed and removed from the codebase