Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade To Expo 52 #1381

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

Upgrade To Expo 52 #1381

wants to merge 32 commits into from

Conversation

finnmerlett
Copy link

@finnmerlett finnmerlett commented Jan 7, 2025

Upgrade To Expo 52

Closes #1054

Changes:

  • Rebuild Expo-related deps from new project created with create-expo-app, upgrading to Expo 52
  • Fresh install all deps to update to latest versions
  • Identify all deprecations/changes from each Expo release, and either addressed in code or marked with FIXME complete later
  • Ensure all deps are suitable with npx expo install expo --fix
  • Check for any possible known issues with npx expo-doctor@latest
  • Upgrade and fixed all ESLint warnings & errors
  • Address all TS errors
  • Get all tests passing
  • Migrate Google Auth from deprecated Expo-proxy method to native package (supported by Expo development builds)
  • Check Apple authentication method and update if necessary - not doing this for now
  • Check push notifications work as expected
  • Check splash-screen methods still work as expected
  • Fix app icon sizing (on android at least)
  • Check core app functionality for approving OTP requests works as expected
  • Check all usages of require are still necessary, migrate any that need it
  • Check integration with CI/CD pipelines still works as expected, fix if not
  • Update docs to reflect move from Expo Go to Expo development builds
  • Check - do we want to enable the new architecture (newArchEnabled: true, which would be set true by default in a new Expo 52 app) - marked as TODO instead
  • Check - do we want to swap to new beta expo-file-system/next API - marked as TODO instead
  • Double-check all FIXME notes have been addressed and removed from the codebase

@finnmerlett finnmerlett changed the title #1054 Upgrade To Expo 52 Upgrade To Expo 52 Jan 7, 2025
@finnmerlett finnmerlett force-pushed the chore/1054-upgrade-to-expo-52 branch from 0ac2279 to f4eb6b3 Compare January 8, 2025 14:53
@finnmerlett finnmerlett force-pushed the chore/1054-upgrade-to-expo-52 branch from bf0d15b to 88cc496 Compare January 10, 2025 02:24
@finnmerlett finnmerlett force-pushed the chore/1054-upgrade-to-expo-52 branch from 88cc496 to a782ec1 Compare January 10, 2025 02:27
@finnmerlett finnmerlett force-pushed the chore/1054-upgrade-to-expo-52 branch from 4caeecf to 25362c3 Compare January 10, 2025 11:45
@finnmerlett finnmerlett force-pushed the chore/1054-upgrade-to-expo-52 branch from e3e1c9a to 05400f0 Compare January 10, 2025 20:24
@finnmerlett finnmerlett force-pushed the chore/1054-upgrade-to-expo-52 branch from 05400f0 to 423e11e Compare January 10, 2025 20:28
@finnmerlett finnmerlett force-pushed the chore/1054-upgrade-to-expo-52 branch from fe6c35d to 6cd018d Compare January 16, 2025 14:27
@finnmerlett finnmerlett force-pushed the chore/1054-upgrade-to-expo-52 branch from ed14a09 to f0ab138 Compare January 16, 2025 18:21
@finnmerlett finnmerlett force-pushed the chore/1054-upgrade-to-expo-52 branch from adab65d to c7b3a95 Compare January 16, 2025 19:05
@finnmerlett finnmerlett force-pushed the chore/1054-upgrade-to-expo-52 branch from c1faaee to 7fcd8bd Compare January 16, 2025 19:49
@finnmerlett finnmerlett force-pushed the chore/1054-upgrade-to-expo-52 branch from 7fcd8bd to 8480f3a Compare January 16, 2025 19:53
Copy link

github-actions bot commented Jan 16, 2025

Original auto-generated comment, containing non-functional links since it was written assuming that project was using Expo Go, which is not the case any more (we are now using Expo development builds):

<!-- app:@nearform/optic-expo channel:pr-1381 -->
Preview available at https://expo.dev/accounts/nearform/projects/optic-expo/updates/5153d169-c5f2-4dbb-844f-6ff493e49dff
<br/> <br/>
Or scan QR Codes...
<br/> <br/>
android:
<br/>
<img src='https://qr.expo.dev/eas-update?updateId=d94a38d5-0f15-45fd-9448-72051217246d&amp;appScheme=exp&amp;host=u.expo.dev' alt='QR Code' />
<br/><br/>
ios:
<br/>
<img src='https://qr.expo.dev/eas-update?updateId=3ce1e527-df6a-43e7-9fae-c4dbe67cfa6f&amp;appScheme=exp&amp;host=u.expo.dev' alt='QR Code' />}

@finnmerlett finnmerlett marked this pull request as ready for review January 16, 2025 20:12
@finnmerlett
Copy link
Author

finnmerlett commented Jan 17, 2025

Visit this link to download and install the apk of the latest build on an android phone: https://expo.dev/accounts/nearform/projects/optic-expo/builds/c943150a-f650-44e7-8819-878f692c390f

Or scan the QR code below:
Screenshot 2025-01-17 at 09 17 15

Comment on lines +99 to +114
console.log('Google sign in cancelled')
}
} catch (error) {
if (GS.isErrorWithCode(error)) {
switch (error.code) {
case GS.statusCodes.IN_PROGRESS:
console.log('Google auth already in progress')
break
case GS.statusCodes.PLAY_SERVICES_NOT_AVAILABLE:
console.log('Google play services not available')
break
default:
console.log('Google sign in error', error)
}
} else {
console.log('An unexpected error occurred,', error)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of just logging errors, this should be surfaced to the user in an alert, toast or notification popup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to latest Expo SDK
1 participant