fix(validate-on-module-load): move validation timing to module load phase #1938
+28
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved an issue where validation was executed during file import, causing unintended side effects. Validation now occurs when the module is loaded, ensuring proper lifecycle alignment.
Example Scenario
The following scenario describes the environment:
There are two entry modules:
ApiModule
andConsumerModule
.In the project's root main.ts, these two modules are imported:
In the current version, all validation functions are executed regardless of the serverType.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
Validation functions in
ConfigModule.forRoot
are executed regardless of module loading.What is the new behavior?
VALIDATED_ENV_LOADER
provider. This ensures it runs during module initialization via NestJS DI and centralizes the responsibility of validating and loading environment variables.Does this PR introduce a breaking change?
Other information