Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add langauge files #46

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Add langauge files #46

wants to merge 7 commits into from

Conversation

circlecube
Copy link
Member

@circlecube circlecube commented Feb 13, 2025

Proposed changes

This adds a po file for each language:

  • Spanish
  • Portuguese (bonus)
  • German
  • Dutch
  • French
  • Italian
  • English (Australia) - which is a copy of the default English
  • English (UK) - another copy of English but updates "trash" to "bin".

These translations were created via crowdin AI assisted translations.
Runs composer run i18n command to:

  • gather all translation strings in pot file
  • update all po files with strings and source lines
  • generate all mo files from latest po files
  • generate all json files from latest po files

This gets us to a starting point for translations. Quick testing shows there are still strings that need to be using i18n functions. It looks like I've got all strings that are using the i18n functions translated by looking at the po files though, so as we make more available we'll need to continually add the translation functions, the pot file should pick it up and copy them into the po files - we'll need to make sure to add the translation though.

There are also sections of the plugin that come from modules that do not have translations for all languages or need to be updated to be i18n/l10n compatible.

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube requested review from wpscholar and a team February 13, 2025 20:50
@circlecube circlecube self-assigned this Feb 13, 2025
@circlecube circlecube changed the base branch from main to develop February 13, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant