Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blocked by core] don't get contacts from disabled address books #192

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

julien-nc
Copy link
Member

As mentioned in #169, contacts from disabled address books were showed on the map and suggested when placing contacts. Address book state is now verified from the database.

@jancborchardt
Copy link
Member

@efelon can you check if this fixes the issue you reported at #169 ? :)

@georgehrke
Copy link
Member

Please note that you are ever only supposed to query ( or insert / update / delete ) tables that your app also created.

oc_properties is a private database table created by the dav app and may change at any time without prior notice.

Meaning, right now there is no officially supported API to get the enabled status of an addressbook in PHP. I created this issue and will try to look into it. nextcloud/server#17537

@julien-nc
Copy link
Member Author

@georgehrke Ok thanks for the feedback.

So we shouldn't merge that for now.

Now let's keep this sleeping until there is an official way to get address book states.

@efelon
Copy link

efelon commented Oct 15, 2019

@jancborchardt in that case there is no need for me to test. I'm aware and will wait for a final solution.

Thanks anyway everyone for looking into it.

@jancborchardt jancborchardt changed the title refs #169 don't get contacts from disabled address books [blocked by core] don't get contacts from disabled address books Oct 15, 2019
@RoBo-OnGitHub
Copy link

RoBo-OnGitHub commented Aug 8, 2022

It seems to be a trivial feature request to hide disabled contacts from showing up in the map. For example if someone has an 'archive' address book.
Meanwhile it should have been possible to get an 'API' agreement with the coders from the contacts app? Otherwise, I would hope that meanwhile we're stop waiting and implement the enable/disable state based on the oc_properties, taking the dependency for granted, while waiting for the API-agreement. As it's taking the functionality down big time.
Hmm it seems that it's even coded about 3 years ago. Why wasn't it released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants