fix: Refactor error handling to leverage thiserror's automatic Displa… #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjudson
approved these changes
Dec 18, 2024
sjudson
pushed a commit
that referenced
this pull request
Feb 5, 2025
* fix * fix test * move opt level test * split up tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update simplifies error handling by removing the manual implementation of the
Displaytrait and relying onthiserror's capabilities to automatically generate it.What has been changed?
Displayimplementations for all error enums.#[error(...)]attribute to each error variant to define error descriptions directly.#[from]is properly used for error conversions, reducing boilerplate code.Why is this better?
thiserrorautomatically implements theDisplaytrait, ensuring consistency and simplifying error handling.#[error(...)], making the code easier to read and maintain.thiserror.This refactor not only simplifies the code but also ensures that all errors are formatted and handled in an idiomatic way.