fix: ensure witness size is power of two #338
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DeVikingMark thanks for taking a pass at this. Looks like tests are failing at the moment, however. |
by chance, do these changes seem alright to you? |
sjudson
approved these changes
Jan 21, 2025
|
@DeVikingMark looks like it needs some formatting + clippy fixes. |
sjudson
requested changes
Jan 21, 2025
|
@DeVikingMark what is the reason for removing an existing test? Also, please run |
sjudson
pushed a commit
that referenced
this pull request
Feb 5, 2025
Summary: Originally, the MemAccessSize value is `n - 1` for short masking code, turn out we didn't use, let's revert it back to original size. Test Plan: Co-authored-by: duc-nx <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #287
Added check to ensure witness size is power of two in
CRR1CSProof::prove()function to prevent potential index out of bounds error when reading from empty vector.Changes made:
This prevents the issue where reading index of zero from an empty vector could occur if the witness size is not a power of two.