chore: update license #6
Conversation
WalkthroughThis pull request makes widespread updates to the repository’s licensing information. Most source files now use an overhauled license header featuring the SPDX identifier BUSL-1.1 with the copyright year updated to 2025, accompanied by detailed legal disclaimers. In addition, the LICENSE file has been updated with revised terms, and a change in the Makefile simplifies the file search. A few files in the simapp directory have had their license headers removed entirely. No functional or control flow changes have been made. Changes
Poem
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
LICENSE (2)
30-31: Clarification in Terms Section:
The added clause indicating that the Licensor may make an Additional Use Grant permitting limited production use is clear. Please verify that this wording accurately reflects the intended legal terms and has received appropriate legal review.
74-95: Covenants of Licensor Update:
The "Covenants of Licensor" section has been extensively updated, detailing new obligations regarding the Change License, Additional Use Grant, and Change Date. Because these legal terms are critical, it is advisable to have this text reviewed by legal counsel to ensure full compliance with internal policies and external regulations.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (39)
.github/license.yml(1 hunks)LICENSE(2 hunks)Makefile(1 hunks)client/cli/tx.go(1 hunks)client/cli/utils.go(1 hunks)e2e/clients_test.go(1 hunks)e2e/fee_test.go(1 hunks)e2e/ownership_test.go(1 hunks)e2e/params_test.go(1 hunks)e2e/upgrade_test.go(1 hunks)e2e/utils.go(1 hunks)genesis.go(1 hunks)keeper/abci.go(1 hunks)keeper/abci_test.go(1 hunks)keeper/keeper.go(1 hunks)keeper/msg_server.go(1 hunks)keeper/msg_server_test.go(1 hunks)keeper/query_server.go(1 hunks)keeper/query_server_test.go(1 hunks)module.go(1 hunks)simapp/app.go(0 hunks)simapp/export.go(0 hunks)simapp/legacy.go(0 hunks)simapp/simd/cmd/commands.go(0 hunks)simapp/simd/cmd/root.go(0 hunks)simapp/simd/main.go(0 hunks)types/codec.go(1 hunks)types/errors.go(1 hunks)types/expected_keepers.go(1 hunks)types/genesis.go(1 hunks)types/keys.go(1 hunks)types/msgs.go(1 hunks)types/params_legacy.go(1 hunks)utils/address.go(1 hunks)utils/mocks/account.go(1 hunks)utils/mocks/authority.go(1 hunks)utils/mocks/bank.go(1 hunks)utils/mocks/upgrade.go(1 hunks)utils/tools.go(1 hunks)
💤 Files with no reviewable changes (6)
- simapp/export.go
- simapp/legacy.go
- simapp/simd/cmd/root.go
- simapp/simd/cmd/commands.go
- simapp/app.go
- simapp/simd/main.go
✅ Files skipped from review due to trivial changes (24)
- types/genesis.go
- types/expected_keepers.go
- utils/mocks/authority.go
- utils/mocks/account.go
- utils/mocks/upgrade.go
- module.go
- types/codec.go
- e2e/params_test.go
- types/errors.go
- e2e/clients_test.go
- keeper/msg_server_test.go
- genesis.go
- types/params_legacy.go
- keeper/msg_server.go
- utils/mocks/bank.go
- e2e/utils.go
- e2e/fee_test.go
- client/cli/tx.go
- types/keys.go
- keeper/abci.go
- utils/address.go
- utils/tools.go
- e2e/ownership_test.go
- types/msgs.go
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: test (TestScheduleUpgrade)
- GitHub Check: test (TestParameterUpdate)
- GitHub Check: test (TestOwnershipTransfer)
- GitHub Check: test (TestBeginBlocker)
- GitHub Check: test (TestClientSubstitution)
🔇 Additional comments (13)
keeper/query_server.go (1)
5-5: Verify the MariaDB BSL link.The referenced URL "www.mariadb.com/bsl11" should be verified to ensure it's the correct and permanent location for the BSL license terms.
✅ Verification successful
🌐 Web query:
Is www.mariadb.com/bsl11 the correct URL for the Business Source License 1.1?💡 Result:
Yes, www.mariadb.com/bsl11 is the correct URL for accessing the official Business Source License (BSL) 1.1 text[9][10]. This URL is explicitly referenced in SPDX documentation as the authoritative source for BSL 1.1 details[9], and it aligns with MariaDB's role as the original creator of this license[5][6].
Key Details About BSL 1.1
- Managed by: MariaDB Corporation Ab[9][10]
- Core Function: A source-available license allowing code modification and redistribution while restricting production use until a specified "Change Date"[2][6]
- Transition Mechanism: Automatically converts to an open-source license (typically GPL) after 4 years or a predetermined date[6][10]
The URL serves as both a licensing reference and a compliance requirement for companies adopting BSL 1.1[7][9]. While MariaDB provides additional explanatory FAQs at
mariadb.com/bsl-faq, the canonical license text resides atwww.mariadb.com/bsl11[6][9].Citations:
- 1: https://www.couchbase.com/blog/couchbase-adopts-bsl-license/
- 2: https://www.dotcms.com/bsl-faq
- 3: https://gitlab.alpinelinux.org/alpine/aports/-/issues/15193
- 4: https://www.hashicorp.com/blog/hashicorp-adopts-business-source-license
- 5: https://mariadb.com/bsl-faq-adopting/
- 6: https://mariadb.com/bsl-faq-mariadb/
- 7: https://akka.io/bsl/license
- 8: https://github.com/clockworklabs/spacetimedb/blob/master/LICENSE.txt
- 9: https://spdx.org/licenses/BUSL-1.1.html
- 10: https://en.wikipedia.org/wiki/Business_Source_License
MariaDB BSL link is correctly referenced.
The URL "www.mariadb.com/bsl11" has been verified as the authoritative and permanent location for the Business Source License 1.1 text, according to the latest web query results.keeper/keeper.go (1)
1-19: License headers are consistently updated across all files.The license headers have been consistently updated across all files with:
- Valid SPDX identifier (BUSL-1.1)
- Current copyright year (2025)
- Comprehensive legal terms and disclaimers
keeper/abci_test.go (1)
1-19: LGTM! License header properly updated.The license header has been correctly updated with:
- SPDX identifier for BUSL-1.1
- Updated copyright year to 2025
- Complete legal terms and disclaimers
keeper/query_server_test.go (1)
1-19: LGTM! License header is consistent.The license header matches the standard format used across the codebase.
.github/license.yml (1)
1-20: LGTM! License template properly configured.The license template in license.yml correctly defines the standard header format for the go-license tool.
Makefile (1)
20-20: LGTM! File search pattern simplified.The FILES variable has been updated to use a more straightforward find command while maintaining the necessary exclusions.
LICENSE (5)
1-7: License Header Update:
The header now correctly reflects the change to "Business Source License 1.1" and the use of curly quotes in line 4 aligns with the updated style guidelines. Please double-check that the separator (line 6) is rendered as intended across all viewports.
10-24: Updated Parameters Section:
The "Licensed Work" is now updated to “Noble Authority Cosmos SDK Module” with the corresponding copyright notice (c) 2025 NASD Inc. Additionally, the "Additional Use Grant" has been revised to "None", and the "Change License" now explicitly states "GNU General Public License v3.0". These changes enhance legal clarity and consistency across the license text.
62-67: Updated Disclaimer Clause:
The disclaimer now uses curly quotes and clearly states that the Licensed Work is provided on an “AS IS” basis with corresponding warranty disclaimers. Confirm that the formatting and phrasing meet the company’s legal documentation standards.
68-73: License Text Usage Grant:
The section granting permission to use the License’s text and refer to the trademark “Business Source License” is now explicit. It is important to ensure that any obligations associated with this usage have been cross-checked with internal guidelines.
97-109: Updated Notice Section:
The Notice clearly explains that the Business Source License is not an Open Source license and provides updated references for further details. Please verify that all URLs (e.g., https://mariadb.com/bsl-faq-mariadb and https://mariadb.com/bsl-faq-adopting) and legal references are current and correct.client/cli/utils.go (1)
1-19: Verify the BSL license URL.The license header references www.mariadb.com/bsl11, which appears to be a generic BSL license URL. Please verify if this is the correct URL for your project's BSL license or if it should point to your organization's specific BSL license terms.
e2e/upgrade_test.go (1)
1-19: Same issue with BSL license URL.The license header has the same reference to www.mariadb.com/bsl11.
Summary by CodeRabbit
These maintenance changes improve legal clarity and build consistency without impacting the end-user functionality or application behavior.