feat: add transformValidatedStripTypes method #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChALkeR
force-pushed
the
chalker/transformValidatedStripTypes
branch
2 times, most recently
from
803a0e0
to
3645e18
Compare
ChALkeR
force-pushed
the
chalker/transformValidatedStripTypes
branch
from
3645e18
to
f7a627a
Compare
ChALkeR
changed the title
| return true; | ||
| } | ||
|
|
||
| export function transformValidatedStripTypes(source: string): string { |
There was a problem hiding this comment.
I would keep just one function transformSync, add a function called validateOptions that checks that options are valid (mode needs to be strip-only when validateResut is true)
And ad the check if validateResult do the assertion
Test the flags and add documentation
bcheidemann
reviewed
Aug 7, 2024
There was a problem hiding this comment.
Imo, ideally there would be a test which asserts a throw when the new check fails. Appreciate this is not straight-forward since doesTSStripTypesResultMatchSource should never fail, but perhaps it can be exported and tested independently of transformValidatedStripTypes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #17
It deliberately does not return anything except
code, as (1) only that is ever needed in strip-only mode (2) anything else would have been unvalidatedOne of the reasons why this is a new method (except for additional options overcomplicating things)