watch: reload env file for --env-file-if-exists #56643
Open
+58
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
anonrig
approved these changes
Jan 17, 2025
JonasBa
commented
Jan 17, 2025
| @@ -104,7 +104,7 @@ async function runWriteSucceed({ | |||
| if (watchFlag !== null) args.unshift(watchFlag); | |||
| const child = spawn(execPath, args, { encoding: 'utf8', stdio: 'pipe', ...options }); | |||
| let completes = 0; | |||
| let cancelRestarts = () => {}; | |||
| let cancelRestarts = () => { }; | |||
There was a problem hiding this comment.
These seem to have changed, however when running make-lint-js or make-lint-js-fix, I dont see any errors?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56643 +/- ##
==========================================
- Coverage 89.21% 89.20% -0.02%
==========================================
Files 662 662
Lines 191883 191883
Branches 36932 36934 +2
==========================================
- Hits 171198 171170 -28
- Misses 13534 13554 +20
- Partials 7151 7159 +8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using watch mode with --env-file-if-exists, reload env correctly
ref: #49148 (comment)