Logging fixes #52
Merged
Logging fixes #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
audiodude
approved these changes
Nov 24, 2024
No two files should have the same name, but this will ensure a fail instead of truncating a previous log
|
using logging_redirect_tqdm actually redirects to stdout when trying to write to a file, working on a fix |
audiodude
reviewed
Nov 25, 2024
audiodude
approved these changes
Nov 25, 2024
|
Added those explanations to the code so it's clear for everyone, should be all set to merge afterwards unless there are any last changes. |
audiodude
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fleshed out some details with the cli/logging including creating an output directory if one doesn't exist and naming logs based on when the program is executed instead of just appending to an existing log.