[FEATURE] Optional encryption of settings.json to prevent exposing password as cleartext. #2635
+261
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ured IIS allows for the downloading of settings.txt or settings.json. In the current state these files store database passwords in as unencrypted clear text. This feature uses dotNet's ProtectedData API (scoped to the account the application is running under) to encrypt the values found in the dataSettings.json file so that in the event the file is exposed the sensitive information isn't available in clear text.
|
Can I join this project? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature addresses the narrow scope security case where misconfigured IIS allows for the downloading of settings.txt or settings.json.
In the current codebase these files store database passwords and user accounts in as unencrypted clear text.
This feature uses dotNet's ProtectedData API (scoped to the account the application is running under) to encrypt the values found in the dataSettings.json file so that in the event the file is exposed the sensitive information isn't available in clear text.