-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): allow pass empty step control value #6992
base: next
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
await this.controlValuesRepository.delete({ | ||
_environmentId: command.environmentId, | ||
_stepId: command.messageTemplateId, | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
till now on every message removal, we had a stale preference entity kept in the db.
in the last week, we added a removal on workflow delete, but in case the workflow is not deleted we would still have those controls.
…trol-upsert # Conflicts: # apps/api/src/app/workflows-v2/usecases/process-workflow-issues/process-workflow-issues.command.ts # apps/api/src/app/workflows-v2/usecases/process-workflow-issues/process-workflow-issues.usecase.ts # apps/api/src/app/workflows-v2/usecases/upsert-workflow/upsert-workflow.usecase.ts # apps/api/src/app/workflows-v2/usecases/validate-control-values/build-default-control-values-usecase.service.ts # apps/api/src/app/workflows-v2/usecases/validate-control-values/build-default-control-values.command.ts
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer