Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): allow pass empty step control value #6992

Open
wants to merge 5 commits into
base: next
Choose a base branch
from

Conversation

djabarovgeorge
Copy link
Contributor

What changed? Why was the change needed?

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for novu-stg-vite-dashboard-poc ready!

Name Link
🔨 Latest commit f5efeed
🔍 Latest deploy log https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/67361c615242f5000831ebef
😎 Deploy Preview https://deploy-preview-6992--novu-stg-vite-dashboard-poc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment on lines +26 to +29
await this.controlValuesRepository.delete({
_environmentId: command.environmentId,
_stepId: command.messageTemplateId,
});
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

till now on every message removal, we had a stale preference entity kept in the db.
in the last week, we added a removal on workflow delete, but in case the workflow is not deleted we would still have those controls.

…trol-upsert

# Conflicts:
#	apps/api/src/app/workflows-v2/usecases/process-workflow-issues/process-workflow-issues.command.ts
#	apps/api/src/app/workflows-v2/usecases/process-workflow-issues/process-workflow-issues.usecase.ts
#	apps/api/src/app/workflows-v2/usecases/upsert-workflow/upsert-workflow.usecase.ts
#	apps/api/src/app/workflows-v2/usecases/validate-control-values/build-default-control-values-usecase.service.ts
#	apps/api/src/app/workflows-v2/usecases/validate-control-values/build-default-control-values.command.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants