feat(#3800): LintMojo prints lints URL #3897
Open
+67
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maxonfjvipon please check this one. Looks like |
|
@h1alexbel you can ignore the file by adding it to |
|
@maxonfjvipon updated. Take a look, please |
maxonfjvipon
requested changes
Feb 7, 2025
| final ConcurrentHashMap<Severity, List<Defect>> counts = new ConcurrentHashMap<>(); | ||
| counts.putIfAbsent(Severity.CRITICAL, new ListOf<>()); | ||
| counts.putIfAbsent(Severity.ERROR, new ListOf<>()); | ||
| counts.putIfAbsent(Severity.WARNING, new ListOf<>()); |
There was a problem hiding this comment.
@h1alexbel why do we need all this stuff with Lists? Only retrieving jus one element and take the version? Looks a bit suboptimal to me
There was a problem hiding this comment.
@maxonfjvipon I agree. But to my knowledge, for now, we can't get the version without defect creation. To find defect, you need to aggregate the list of defects, not its count. I also thought about returning version in Program or Programs from lints like this:
final Programs programs = ...;
final String version = programs.version();WDYT? Maybe we should implement such functionality in lints?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I've updated LintMojo to print URL with current lints version.
closes #3800