Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dispatch questions to Kueue #12

Open
wants to merge 56 commits into
base: main
Choose a base branch
from
Open

Dispatch questions to Kueue #12

wants to merge 56 commits into from

Conversation

cortadocodes
Copy link
Member

@cortadocodes cortadocodes commented Jan 23, 2025 •
edited
Loading

Contents (#12)

New features

  • Dispatch questions as Kueue jobs (optional; on by default)

Enhancements

  • Improve log messages

Operations

  • Improve installation in release workflow testing

Dependencies

  • Add kubernetes

Refactoring

  • Rename cloud function entrypoint to handle_event

Style

  • Switch to ruff linter

@cortadocodes cortadocodes self-assigned this Jan 23, 2025
@cortadocodes cortadocodes marked this pull request as draft January 23, 2025 17:38
@cortadocodes
ENH: Pass environment variables into Kueue container
8b11007
@cortadocodes
ENH: Add OCTUE_SERVICES_TOPIC envvar and rename other envvars
8a3aab4
@cortadocodes
CHO: Add ruff config
104faa9
@cortadocodes
REF: Rename variable
6d47a80
@cortadocodes
FIX: Get environment variables at runtime, not import time
abba7fe
@cortadocodes
TST: Fix tests
9363844
@cortadocodes
REF: Rename cloud function entrypoint to handle_event
619329e
@cortadocodes
FIX: Fix envvar names
0d8cb20
@cortadocodes
ENH: Improve log message
6f4456d
@cortadocodes
TST: Test dispatching questions to Kueue
3579eb9
@cortadocodes
TST: Factor out some variables in tests
61efb61
@cortadocodes
ENH: Pass event attributes to Kueue container
e52e5fd
@cortadocodes
OPS: Remove redundant envvar from tests in workflows
3285de1
@cortadocodes
TST: Patch kube config in tests
9336d92
@cortadocodes
ENH: Allow disabling Kueue question dispatch
3538a47
@cortadocodes
OPS: Improve installation in release workflow testing
7a1e773 
skipci
@cortadocodes
REF: Consolidate imports
78c5695
@cortadocodes
FIX: Fix ability to disable Kueue
be115a6
@cortadocodes
ENH: Improve log messages
5b2b37a
@cortadocodes
REF: Rename _dispatch_kueue_job to _dispatch_question_as_kueue_job
165557e
@cortadocodes
ENH: Allow compute resource requests in question attributes
ec4707d
@cortadocodes
TST: Simplify test
1bea5ef
@cortadocodes cortadocodes marked this pull request as ready for review January 27, 2025 17:05
@cortadocodes cortadocodes changed the title Dispatch questions to kueue Dispatch questions to Kueue Jan 27, 2025
@cortadocodes
FIX: Remove explicit kubernetes configuration
64dc247 
skipci
@cortadocodes
FIX: Configure kubernetes cluster host IP
1f3ad57
@cortadocodes
FIX: Configure kubernetes client properly
8aca753
@cortadocodes
FIX: Remove periods from job name
d12258a 
skipci
@cortadocodes
FIX: Shorten job and container names
66e638b 
skipci
@cortadocodes
FIX: Fix envvar name
2287d0c 
skipci
@cortadocodes
FIX: Set kubernetes service account for job from envvar
975c1c0 
skipci
@cortadocodes
FEA: Add outline of service registry cloud function
bf66692
@cortadocodes
ENH: Add endpoint for service revision existence check
b691405
@cortadocodes
ENH: Return 400 if revision_tag parameter not supplied
14aaf33 
skipci
@cortadocodes
DEP: Add missing dependency
fc6c8ac
@cortadocodes
DOC: Add docstrings
9e9ae91
@cortadocodes
OPS: Upload service registry source code to bucket on release
daa98c0
@cortadocodes
TST: Update test
d5892fa
@cortadocodes
DOC: Add docstring
d1c935d
@cortadocodes
TST: Remove need for GCP credentials to run tests
4a92d82
@cortadocodes
FIX: Use correct request attributes
94474ac 
skipci
@cortadocodes
FIX: Get envvar at runtime
6b649cc
@cortadocodes
ENH: Add ability to request ephemeral storage for Kueue job
1d3ffc1 
skipci
@cortadocodes
ENH: Reduce default resource request
fb7267d
@cortadocodes
ENH: Get default question resources from envvars
28f1984
@cortadocodes
FIX: Fix typo in attribute name
12d5450 
skipci
@cortadocodes
FIX: Convert CPUs number to int
541fa37
@cortadocodes
ENH: Make Kueue usage mandatory
44277cf
@cortadocodes
FIX: Fix resource request names
9c757a6 
skipci
@cortadocodes
FIX: Fix ephemeral-storage resource request name
e58379b
@cortadocodes
FEA: Cancel Kueue job on receipt of cancellation event
3c4e2d1 
skipci
@cortadocodes
TST: Update tests
240a5a2
@cortadocodes
TST: Test handling cancellation event
55a5f5f
@cortadocodes
REF: Rename function
ff9496f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cortadocodes cortadocodes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cortadocodes