[core/simd]: Write package documentation #4545
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laytan
reviewed
Dec 3, 2024
Co-authored-by: Laytan <[email protected]>
flysand7
commented
Dec 4, 2024
| } | ||
| return res | ||
|
|
||
| Example: |
There was a problem hiding this comment.
Ah! I should fix this then. I haven't read your comments below, but it should be okay to surround the code block with text that describes what the example achieves, right? Otherwise I feel like the purpose of example is defeated, unless it's explained at least a little bit.
| +-------+-------+-------+-------+ | ||
| res: | ||
| +-------+-------+-------+--------+ | ||
| | 0x44 | 0xaa | 0x06 | 0xfe | |
There was a problem hiding this comment.
Okay this one I have to refuse, I was assuming 1-byte lanes, which I should probably make explicit in the comments.
core/simd/simd.odin
Outdated
| /* | ||
| Saturated addition of SIMD vectors. | ||
|
|
||
| The *saturated sum* is a sum, that upon overflow or underflow, instead of |
There was a problem hiding this comment.
Yes, I should rewrite this.
| res := simd.gather(ptrs, defaults, mask) | ||
| fmt.println(res) | ||
|
|
||
| The code would print `<2, 127, 10, 127>`. First and the third positions came |
There was a problem hiding this comment.
They are indented with a tab. Thanks for Output: tip!
Co-authored-by: Laytan <[email protected]>
gingerBill
reviewed
Dec 4, 2024
|
Did some fixes, I think this one's ready for the final review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.