FujiReader: ensure getCurrentFile is the first element of the used files list #4267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melissalinkert
requested changes
Jan 17, 2025
| @@ -118,7 +118,7 @@ public String[] getSeriesUsedFiles(boolean noPixels) { | |||
| if (noPixels) { | |||
| return new String[] {infFile}; | |||
| } | |||
| return new String[] {infFile, pixelsFile}; | |||
| return new String[] {pixelsFile, infFile}; | |||
There was a problem hiding this comment.
While this causes the test to pass, it looks like it shifts the problem to initializing .inf files:
$ showinf -no-upgrade -nopix TPN_membraneC_1sec.inf
Checking file format [Fuji LAS 3000]
Initializing reader
FujiReader initializing TPN_membraneC_1sec.inf
Initialization took 0.179s
Reading core metadata
filename = TPN_membraneC_1sec.inf
Used files:
/home/melissa/data/bf-data-repo/automated-tests/curated/fuji/venu/TPN_membraneC_1sec.img
/home/melissa/data/bf-data-repo/automated-tests/curated/fuji/venu/TPN_membraneC_1sec.inf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4172 for background