Fix Connector hover state goes off the page and file connector button… #3873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Deletion of File connector would be blocked by this change as now I can't have it in Paused state anymore.
So either we need to have the connector be paused on success for File connector specifically or we need to allow the delete for File connector when not paused (ensure that this works end to end) |
jenny-onyx
force-pushed
the
file_connector_button_ui_issue
branch
from
b8f11b9 to
92f5ec8
Compare
jenny-onyx
force-pushed
the
file_connector_button_ui_issue
branch
from
92f5ec8 to
d174826
Compare
|
Looks and works correctly, nice job! Preference for logic here though that it should be like before (centered above the button) if it fits within the screen, and only change it if it goes off the screen to the right |
… issue update file connector status to paused after succefully indexing
jenny-onyx
force-pushed
the
file_connector_button_ui_issue
branch
from
d174826 to
43b13e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… issue
Description
[Connector hover state goes off the page]
How Has This Been Tested?
Tested in the UI
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.