Connector checkpointing #3876
Open
Connector checkpointing #3876
+3,169
−1,041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Weves
force-pushed
the
connector-checkpointing
branch
from
b0e50cf to
f69739e
Compare
Weves
commented
Feb 4, 2025
Weves
commented
Feb 4, 2025
Weves
commented
Feb 4, 2025
Weves
commented
Feb 4, 2025
rkuo-danswer
reviewed
Feb 4, 2025
backend/alembic/versions/b7a7eee5aa15_add_checkpointing_failure_handling.py
Show resolved
Hide resolved
| if (failed_document is None and failed_entity is None) or ( | ||
| failed_document is not None and failed_entity is not None | ||
| ): | ||
| raise ValueError( |
There was a problem hiding this comment.
Should this be a Union type then?
There was a problem hiding this comment.
Hmm, to me tradeoffs for each. using isinstance to check type (which is necessary if using Union type) feels bad, thus this approach
| except Exception as e: | ||
| logger.exception( | ||
| "Connector run exceptioned after elapsed time: " | ||
| f"{time.time() - start_time} seconds" |
There was a problem hiding this comment.
time.monotonic probably better here?
Weves
force-pushed
the
connector-checkpointing
branch
from
320b62d to
debc79a
Compare
more stuff for checkpointing Basic implementation FE stuff More checkpointing/failure handling rebase rebase initial scaffolding for IT IT to test checkpointing Cleanup cleanup Fix it Rebase Add todo Fix actions IT Test more Pagination + fixes + cleanup Fix IT networking fix it
Weves
force-pushed
the
connector-checkpointing
branch
from
3f8701d to
5b06b95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://linear.app/danswer/issue/DAN-1400/connector-checkpointing-continue-on-failure
How Has This Been Tested?
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.