Add special case to time_str_to_utc
to handle invalid tz names
#3922
+41
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #3921
tl;dr: malformed date strings are being returned from the Gmail API and being passed to the
time_str_to_utc
function here:onyx/backend/onyx/connectors/gmail/connector.py
Line 182 in 5c7487e
This is the least obtrusive solution I could come up with:
+1234 (SOMETHING)
)Another option would be to use fuzzy parsing (i.e.
dt = parse(datetime_str, fuzzy=True)
) but that risks causing surprising behaviour elsewhere, given how widely this util is used.How Has This Been Tested?
Added unit tests.
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.