refactor: rename pro search to agent search across codebase #3925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Co-Authored-By: Chris Weaver <[email protected]>
Co-Authored-By: Chris Weaver <[email protected]>
…igration Co-Authored-By: Chris Weaver <[email protected]>
…tend interfaces Co-Authored-By: Chris Weaver <[email protected]>
Co-Authored-By: Chris Weaver <[email protected]>
Co-Authored-By: Chris Weaver <[email protected]>
Co-Authored-By: Chris Weaver <[email protected]>
Co-Authored-By: Chris Weaver <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Co-Authored-By: Chris Weaver <[email protected]>
Co-Authored-By: Chris Weaver <[email protected]>
Co-Authored-By: Chris Weaver <[email protected]>
Weves
reviewed
Feb 6, 2025
| @@ -196,8 +196,8 @@ interface ChatInputBarProps { | |||
| availableDocumentSets: DocumentSet[]; | |||
| availableTags: Tag[]; | |||
| retrievalEnabled: boolean; | |||
| proSearchEnabled: boolean; | |||
| setProSearchEnabled: (proSearchEnabled: boolean) => void; | |||
| proSearchEnabled: boolean; // TODO: rename to agentSearchEnabled in a future PR | |||
There was a problem hiding this comment.
why are these TODOs? Can we just do them now?
Co-Authored-By: Chris Weaver <[email protected]>
Weves
reviewed
Feb 6, 2025
web/src/app/chat/ChatPage.tsx
Outdated
| @@ -204,14 +205,19 @@ export function ChatPage({ | |||
| const enterpriseSettings = settings?.enterpriseSettings; | |||
|
|
|||
| const [documentSidebarToggled, setDocumentSidebarToggled] = useState(false); | |||
| const [proSearchEnabled, setProSearchEnabled] = useState(proSearchToggled); | |||
| const [agentSearchEnabled, setAgentSearchEnabled] = useState<boolean>( | |||
| Cookies.get(LEGACY_PRO_SEARCH_TOGGLED_COOKIE_NAME)?.toLowerCase() === | |||
There was a problem hiding this comment.
why did we add this? I suspect we're checking these somewhere else and passing it in as proSearchToggled
Co-Authored-By: Chris Weaver <[email protected]>
Co-Authored-By: Chris Weaver <[email protected]>
Co-Authored-By: Chris Weaver <[email protected]>
Co-Authored-By: Chris Weaver <[email protected]>
Co-Authored-By: Chris Weaver <[email protected]>
Co-Authored-By: Chris Weaver <[email protected]>
Co-Authored-By: Chris Weaver <[email protected]>
Co-Authored-By: Chris Weaver <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comprehensive rename from pro search to agent search across frontend, backend, and database.
Changes:
Implementation Details:
Testing:
Link to Devin run: https://app.devin.ai/sessions/f9ccb3ea429b462ea8c7b7c611e74dde
Requested by: Chris